Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommerceDelivery module #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alessandrocraeye
Copy link
Contributor

Adds a new shipment method where the shipping cost can be set per country. If no country is enabled it falls back to the default delivery pricing.

Validation still needs to be added so only the available country / method is shown based on the shipment address provided by the customer.

Copy link
Member

@jessedobbelaere jessedobbelaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great!

There seems to be a test failing EditTest.php:41 🤔

@alessandrocraeye
Copy link
Contributor Author

There's still an issue with the test failing on the foreach in Quote.php:24. Not sure how I should supply the shipmentMethod countries to the module settings in order for them to be available in the test.

@jessedobbelaere
Copy link
Member

Hmm weird, can you enable "Allow write-access for maintainers" in the settings of this PR? I can try to push a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants