Clean Validation Reports Job #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added config option `clean_validation_reports`. - Added job to delete validation reports from unsupported formats.
ThrawnCA
suggested changes
Nov 8, 2023
- Used `get_action` from toolkit instead of ckanapi dependency. - Removed `url_changed` check.
- Better logging. - Added `asbool` for `validation_status` checks.
ThrawnCA
reviewed
Nov 9, 2023
ThrawnCA
reviewed
Nov 9, 2023
- Added falsy check for `url_type`.
ThrawnCA
reviewed
Nov 13, 2023
- Removed `lower` call in logging. - Fixed falsy check on `url_type`.
|
@ThrawnCA |
ThrawnCA
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(jobs): added job to delete validation reports;
clean_validation_reports.This adds the possible feature (controlled by config option) to delete validation reports for unsupported formats. This is useful in the case that a user updates a Resource to no longer be a format that goes through validation, but the validation report and badge remains. So this helps with keeping the validation table size down a bit, and helps showing the correct validation badge (or lack there of)