Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema editor integration #25

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Schema editor integration #25

wants to merge 20 commits into from

Conversation

roll
Copy link
Member

@roll roll commented Mar 15, 2018

Control flow

  • we listen for #field-schema[-url]/[-json] changes
  • on changes we render tableschemaUI.EditorSchema with url/File/text as descriptor and onSave callback
  • user do her schema edits
  • on tableschemaUI.EditorSchema save click the component calls onSave(descriptor)
  • we set descriptor to #field-schema value

Related

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.449% when pulling e70cfd4 on validation-schema into ed1c692 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.449% when pulling e70cfd4 on validation-schema into ed1c692 on master.

@coveralls
Copy link

coveralls commented Mar 15, 2018

Coverage Status

Coverage decreased (-0.2%) to 85.892% when pulling 78710ae on validation-schema into 9ce634a on master.

@roll
Copy link
Member Author

roll commented Apr 3, 2018

@amercader
To run ckan with schema editor:

  • checkout docker-ckan-unhcr/pull/6
  • docker-compose -f docker-compose.val.yml up

@roll
Copy link
Member Author

roll commented Apr 4, 2018

Known issues

@roll roll requested a review from amercader April 10, 2018 15:04
@roll roll changed the title [WIP] Schema editor integration Schema editor integration Apr 10, 2018
@roll
Copy link
Member Author

roll commented Apr 10, 2018

@amercader
Can you please review?

I've made the user control flow changes we've discussed (an issue for the schema editing - #34). A few things which are not resolved (please help if you can):

@@ -98,18 +127,41 @@ this.ckan.module('resource-schema', function($) {
.on('click', this._onRemoveURL)
.insertBefore(this.field_url_input);

// TODO: disable?
Copy link
Member Author

@roll roll Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amercader
Can you please take a look how it works now?

TBH I feel like I'm missing something regarding your comment here - #34 (comment). And because of the bad sound quality haven't got fully your explanation during our call.

Of course, I'm pretty neutral on enabling/disabling the linked schema editing - just curious why the user can't edit the linked schema based on the same approach we have for the create resource page.

@roll roll added this to Software in Frictionless General Mar 19, 2019
@roll roll moved this from Software to In progress in Frictionless General Mar 19, 2019
@roll roll moved this from Pull Requests to Software in Frictionless General Mar 25, 2019
@roll roll moved this from Software to Pull Requests in Frictionless General Mar 25, 2019
@roll roll moved this from Pull Requests to Software in Frictionless General Mar 25, 2019
@roll
Copy link
Member Author

roll commented Apr 15, 2019

@amercader
Are you able to remember what's this?)) I can't)

Have we integrated it already?

@roll roll added the review label Apr 15, 2019
@roll roll added wip and removed review labels Jun 10, 2019
@roll roll moved this from Software (core) to Software (contrib) in Frictionless General Jul 15, 2019
@roll roll removed the wip label Sep 3, 2019
@amercader amercader mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Frictionless General
  
Software (wide)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants