Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Chore) docker installation method for fresns #22

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

ife-adewunmi
Copy link

No description provided.

@mouyong
Copy link
Member

mouyong commented Nov 20, 2023

Hello, @ife-adewunmi. Thank you for your efforts and contributions. Based on the following considerations, we do not recommend merging this PR at this time:

  1. This PR directly updates the main program, Fresns root directory, and adds Dockerfile and other files in the root directory of the main program by default. Some users will not configure dockers and use them. So you can consider moving the relevant files to the deployment directory and providing containerized operation documents.

  2. In your configuration, you have changed the default configuration of nginx. nginx itself has a default root directory, and it is not recommended to modify it for this reason. This will increase the problem of file management, configuration synchronization, and other issues.

  3. The dockerfile and related files in this PR can be used for development environments, but are not suitable for production environments.

If you are interested, we can explore how to provide a containerized development and production environment for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants