Code quality improvements in the DataPipeline and *Pool classes
#948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`priority` has become a required parameter and no longer has a default value. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
With this, all the `*_pool` methods will be next to each other, and making edits to all of them at the same time becomes easier. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
This allows all `*Pool` classes to have the same signature. This commit also renames the corresponding private variable in all the `*Pool` classes to `self._pool_ref_store`. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
There's going to be more parameters soon, so this would be make it easier to read. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
github-actions
bot
added
part:tests
shsms
added
the
cmd:skip-release-notes
|
Internal changes only, no release notes needed. |
llucax
approved these changes
May 15, 2024
Merged
via the queue into
frequenz-floss:v1.x.x
with commit May 15, 2024
e4c9fe9
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more cleanup in preparation for adding support for incremental power actors in the
PowerManager.