Fix done.txt naming bugs #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should do more rigourous testing before pushing... Now it should be all good |
Two unreported done.txt naming bugs fixed: 1. *.Todo.txt files would use *.done.txt for the done filename 2. When a user had the ignorecase option set, the done.txt file was always named Done.txt, because the == operator ignores the case when this option is set. The bugs were introduced in PR freitass#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two unreported done.txt naming bugs fixed:
*.Todo.txt files would use *.done.txt for the done filename
When a user had the ignorecase option set, the done.txt file was
always named Done.txt, because the == operator ignores the case when
this option is set.
The bugs were introduced in PR #73
Further readings on the topic: