Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsystem: allow building custom buildtypes #2781

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

buildsystem: allow building custom buildtypes #2781

wants to merge 2 commits into from

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Feb 5, 2023

This adds GLUON_BUILDTYPE, which is an option that allows specifying an alternate
base configuration

Other additions:

  • GLUON_PREFIX option to specify the filename prefix, if
    VERSION_DIST is set

  • Skip gluon target-definitions if TARGET_ALL_PROFILES is set

  • Allow overriding any file in targets/ by adding the file to site/

    • Allow loading the original file using include_gluon() from gluon

@github-actions github-actions bot added 3. topic: build This is about the build system 3. topic: hardware Topic: Hardware Support 3. topic: package Topic: Gluon Packages labels Feb 5, 2023
@mkg20001
Copy link
Member Author

mkg20001 commented Feb 5, 2023

This is a continuation of the work in #2142

@mkg20001
buildsystem: allow building custom buildtypes
e5be1a6 
This adds GLUON_BUILDTYPE, which is an option that allows specifying an alternate
base configuration

Other additions:

- GLUON_PREFIX option to specify the filename prefix, if
  VERSION_DIST is set

- Skip gluon target-definitions if TARGET_ALL_PROFILES is set

- Allow overriding any file in targets/ by adding the file to site/
  - Allow loading the original file using include_gluon() from gluon
@mkg20001
gluon-core: add option to exclude upgrade scripts that alter system i…
7fe4581 
…nvasivly

This allows the user to build a "vanilla" image that can still include 
gluon components such as gluon-mmfd easily
@mkg20001
Copy link
Member Author

mkg20001 commented Feb 5, 2023

to give some context about mixing gluon and vanilla/luci: this is planned to be used as a way to get respondd, mmfd, etc working on devices where there needs to be a lot of custom config that otherwise can't be done with gluon. but it can also be used in a way similar to the previous pr, where built images simply have a gluon-free custom package set.

@mkg20001 mkg20001 marked this pull request as ready for review February 22, 2023 20:04
@AiyionPrime AiyionPrime added the 2. status: waiting-on-review Awaiting review from the assignee but also interested parties. label Feb 22, 2023
@mkg20001
Copy link
Member Author

requested changes:

  • gluon packages that are usable outside of gluon should be moved to packages repo, instead of hacking gluon to be usable outside of context
  • instead of many custom options there should be a way to replace the lua files that are pulled in (for ex GLUON_CUSTOM_BUILDCONFIGURATION)

@AiyionPrime AiyionPrime added 2. status: waiting-on-author Waiting on some action from the author and removed 2. status: waiting-on-review Awaiting review from the assignee but also interested parties. labels Feb 24, 2023
@mkg20001 mkg20001 marked this pull request as draft February 24, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. status: waiting-on-author Waiting on some action from the author 3. topic: build This is about the build system 3. topic: hardware Topic: Hardware Support 3. topic: package Topic: Gluon Packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkg20001 @AiyionPrime