Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close serial connection for ZeDMD on Dispose(), #475

Merged
merged 2 commits into from
May 26, 2024

Conversation

mkalkbrenner
Copy link
Contributor

closes #474

@mkalkbrenner mkalkbrenner changed the title Close serial connection for ZeDMD on Dispaose(), Close serial connection for ZeDMD on Dispose(), May 11, 2024
@freezy
Copy link
Owner

freezy commented May 18, 2024

#477 fixes the multi disposal. You should open the connection on Init() and close it on Dispose(). Does that make this PR obsolete?

@mkalkbrenner
Copy link
Contributor Author

#477 fixes the multi disposal. You should open the connection on Init() and close it on Dispose(). Does that make this PR obsolete?

No, at the moment we don't close the connection on Dispose(). So the PR should be required.

The downside is that you can't open multiple subsequent tables in VPX anymore but need to close VPX after each table.

@freezy
Copy link
Owner

freezy commented May 21, 2024

The downside is that you can't open multiple subsequent tables in VPX anymore but need to close VPX after each table.

What's the upside, then? ;)

@mkalkbrenner
Copy link
Contributor Author

mkalkbrenner commented May 24, 2024

If you use a frontend that uses dmdext to show something on the DMD, the connection needs to be closed before VPX gets started. That's how the other DMDs behave as well.

@freezy freezy merged commit ab2f110 into freezy:master May 26, 2024
@freezy freezy deleted the zedmd_dispose branch May 26, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZeDMD starts screensaver when starting a table from frontend
2 participants