Alphanumeric Padding #472
Alphanumeric Padding #472
Conversation
Changed Outer Padding and Line Padding for Alphanumeric Displays to use value from DMDDevice.ini
|
Just to keep it neat, I closed the previous pull request and based my new pull on a topic branch. Please refer to issue #456 |
|
Is this usable now then? |
|
Not yet. Freezy will have to merge with his main branch and publish a release. If you want an interim solution, see my existing branch here: https://github.com/buffdriver/dmd-extensions/releases/tag/v2.2.1 My branch is still on 2.2.1, so any of the ZeDMD improvements are not in my branch currently. |
|
Awesome, thanks! I've pushed some changes that fix the preview and main window not being updated in the settings dialog. The remaining problem is that the canvas size should probably update as well, no? |
|
Also, wouldn't you want to be able to control |
|
To my way of thinking, I would like to leave the canvas size alone. I would size my canvas to fit the available space and play with the padding until it was at the most effective value.
… On May 2, 2024, at 6:22 PM, freezy ***@***.***> wrote:
Awesome, thanks! I've pushed some changes that fix the preview and main window not being updated in the settings dialog.
The remaining problem is that the canvas size should probably update as well, no?
—
Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYDYRCDGOX3LOPEYWSNULDZALDCTAVCNFSM6AAAAABG4KKQSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRHA4TSMZTHE>.
You are receiving this because you authored the thread.
|
|
To be honest, I don’t really understand what SegmentPadding does. I found OuterPaddingPercentage to have the desired effect. LinePaddingPercentage seemed like it might come into play, but you’re probably right about just including all three.
… On May 2, 2024, at 6:23 PM, freezy ***@***.***> wrote:
Also, wouldn't you want to be able to control SegmentPaddingPercentage as well?
—
Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYDYRC2MWTTQTLU7B7UKCLZALDGLAVCNFSM6AAAAABG4KKQSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRHA4TSOJWGM>.
You are receiving this because you authored the thread.
|
| public float LinePad { get; set; } = 0.2f; | ||
|
|
||
| /// <summary> | ||
| /// Outer padding percentage | ||
| /// </summary> | ||
| public float OuterPad { get; set; } = 0.2f; |
There was a problem hiding this comment.
You're dividing those by 100 later, shouldn't they be 20 instead of 0.2?
…ter closing with X.
|
Yes, it should be. I struggled with whether to store a whole number percentage or the floating number in the .ini file. Since the slider doesn’t work well with numbers less than one, I settled on the former but forgot to change the initialization. Rookie mistake :)
Thank you!
… On May 3, 2024, at 1:32 AM, freezy ***@***.***> wrote:
@freezy commented on this pull request.
In LibDmd/Output/Virtual/AlphaNumeric/RasterizeStyle.cs <#472 (comment)>:
> + public float LinePad { get; set; } = 0.2f;
+
+ /// <summary>
+ /// Outer padding percentage
+ /// </summary>
+ public float OuterPad { get; set; } = 0.2f;
You're dividing those by 100 later, shouldn't they be 20 instead of 0.2?
—
Reply to this email directly, view it on GitHub <#472 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYDYRGMYIA4OP3RH3VEYSTZAMVRLAVCNFSM6AAAAABG4KKQSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZXGQ3TGNZSHE>.
You are receiving this because you authored the thread.
|
|
Merged! Sorry it took so long. And thanks a lot! ❤️ |
|
Thank you for all that you do! I'm honored to be a very tiny part of it! |
|
Yes, I forgot, a new contributor! Cheers! 😄 |
Changed Outer Padding and Line Padding for Alphanumeric Displays to use value from DMDDevice.ini