Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Only copy the nested spheremorph folder #1187

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

avnishks
Copy link
Contributor

@avnishks avnishks commented Mar 7, 2024

No description provided.

@avnishks avnishks self-assigned this Mar 7, 2024
@yhuang43
Copy link
Contributor

yhuang43 commented Mar 8, 2024

There is a setup.py in the directory. Should we install the package using that like 'qatools' does?

@avnishks
Copy link
Contributor Author

avnishks commented Mar 8, 2024

We could! Spheremorph's installation script needs testing/works to make it compatible with all the combinations of different OS and fspython installation supported by FS.

This PR is essentially a short-term fix to unblock Rob. He is running into problems with linux installation tooling because, in it's current form, these two packages get copied over with similar named nested folders:
python/packages/ERC_bayesian_segmentation/ERC_bayesian_segmentation
python/packages/spheremoprh/spheremorph

@yhuang43
Copy link
Contributor

yhuang43 commented Mar 8, 2024

Ok. Just curious, do current scripts need to be updated to reflect the change?

@avnishks
Copy link
Contributor Author

avnishks commented Mar 8, 2024

Probably. I still another commit to add to this PR before I can merge. Will update any scripts if needed. Thanks!

@jnolan14
Copy link
Contributor

jnolan14 commented Mar 8, 2024

Let me know if you need any help looking into the ERC_bayesian files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants