Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH - matlab code; build in support for multiframe dicom files #1127

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

schoffelen
Copy link
Contributor

This is a long shot, and feel free to ignore, but this PR implements support for multiframe dicoms in the matlab reader.

Context: the Siemens Skyra scanner at the Donders Institute now natively creates multiframe dicoms since a recent software update. Our FieldTrip code (https://github.com/fieldtrip/fieldtrip) relies on load_dicom_fl.m for the reading of dicom anatomical volumes. Given the different formatting of the header (and data) this now fails for obvious reasons.

I could easily implement a workaround that does not touch freesurfer functions, but on the off chance that you find this addition useful, I still submit it here, realizing that:

  • the matlab code probably does not have the focus of attention of the developers
  • core functionality (e.g. mri_convert) does not seem to support multiframe dicoms, so it could have been a conscious design choice not to support this particular file format (although I couldn't find anything about this when doing a shallow online search)
  • I only tested the changed code on a few files that were collected at the Donders Institute, so I don't know how robust it is

@schoffelen
Copy link
Contributor Author

Hello, is there anything related to this PR which prevents it from being picked up by the developers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant