Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization-pulltight45degree #302

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Djzhan0207
Copy link
Contributor

@Djzhan0207 Djzhan0207 commented May 11, 2024

This is an optimization for pulltight-45degree algorithm.
It can improve the performance when the PCB is very dense and the mode is under 45 °.

@Djzhan0207
Copy link
Contributor Author

Djzhan0207 commented May 11, 2024

Freerouting uses too much memory is mainly because its searching queue has too many elements。
The endless loop is because Simplex.java 's intersection function has a endless loop,it occurs when
a rectangle trying to intersect with an irregular borderline shape.Improving this algorithm or when this situations happens,
stoping it and restarting router cound help。

@L1uTongweiNewAccount
Copy link

Thank you, now I will use your code to solve my routing.

@andrasfuchs
Copy link
Collaborator

@L1uTongweiNewAccount Did you have the chance to test this modification? Does it work as you expected?

Copy link
Collaborator

@andrasfuchs andrasfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you commented out a few lines. It would be preferable if you completely removed them. Could you do that before I accept this PR?

@andrasfuchs
Copy link
Collaborator

Interestingly when I run the router with this PR it gets stuck at pass 8:

image

I used the following parameters:
-de .\tests\Issue297-myboard.dsn -do .\tests\Issue297-myboard.ses

This PR is still an improvement in this case, because the original code is stuck at the first pass.

@Djzhan0207
Copy link
Contributor Author

Stuck is mainly because the endless loop mentioned above. This PR is just a time saver for dense PCB.
You can remove the code's comment.
I think 90 router with 45 pulltight could route more fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants