Issue 9591 - Allow get_ruv() to handle incomplete RUV elements #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreynolds389
force-pushed
the
cleanallruv
branch
2 times, most recently
from
6b7a86b
to
ae979c7
Compare
Sometimes RUV's are missing the LDAP Url and max/min csns. This prevents cleanallruv task from running. However, cleanallruv doesn't need to know the LDAP URL or min/max csns. Added a new paramter to get_run() called "strict", and when set to False it will still process and include incomplete RUVs. Fixes: https://pagure.io/freeipa/issue/9591 Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
mreynolds389
added
needs review
|
I could not reproduce the original issue with faulty/incomplete RUVs, but other testing shows this could work as expected now. |
rcritten
reviewed
May 13, 2024
|
Code is working. What branches do we want to backport this too? |
IMHO this should go into all active branches... |
rcritten
added
ipa-4-9
|
master:
|
|
@mreynolds389 manual backports for ipa-4-10 and ipa-4-9 branches are necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes RUV's are missing the LDAP Url and max/min csns. This prevents cleanallruv task from running. However, cleanallruv doesn't need to know the LDAP URL or min/max csns. Added a new paramter to get_run() called "strict", and when set to False it will still process and include incomplete RUVs.
Fixes: https://pagure.io/freeipa/issue/9591