Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed 'config_file_version' option from 'sssd.conf' #7341

Closed
wants to merge 1 commit into from
Closed

Removed 'config_file_version' option from 'sssd.conf' #7341

wants to merge 1 commit into from

Conversation

alexey-tikhonov
Copy link
Contributor

This option is obsolete / doesn't have meaning quite some time already. It wasn't required as well.
Starting sssd-2.10 it's removed altogether.

@rcritten
Copy link
Contributor

rcritten commented May 8, 2024

Change looks good, thanks. Can you add a signed-off-by to your commit?

@alexey-tikhonov
Removed 'config_file_version' option from 'sssd.conf'
bf46b40 
This option is obsolete / doesn't have meaning quite some time already.
It wasn't required as well.
Starting sssd-2.10 it's removed altogether.

Signed-off-by: Alexey Tikhonov <atikhono@redhat.com>
@alexey-tikhonov
Copy link
Contributor Author

Can you add a signed-off-by to your commit?

Done.

And JFTR

@rcritten rcritten added the re-run Trigger a new run of PR-CI label May 9, 2024
@rcritten
Copy link
Contributor

rcritten commented May 9, 2024

One more question. Do you have any thoughts on what branches this should land in? IPA 4.11+ I assume?

@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label May 9, 2024
@alexey-tikhonov
Copy link
Contributor Author

One more question. Do you have any thoughts on what branches this should land in? IPA 4.11+ I assume?

It's important on platforms where sssd-2.10+ will land: f-41, C10S, maybe RHEL9.6+
It won't hurt with older sssd though.

@rcritten rcritten added re-run Trigger a new run of PR-CI ipa-next Mark as master (4.12) only labels May 10, 2024
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label May 10, 2024
@rcritten rcritten added ipa-4-11 Mark for backport to ipa 4.11 ack Pull Request approved, can be merged and removed ipa-next Mark as master (4.12) only ack Pull Request approved, can be merged labels May 13, 2024
@rcritten
Copy link
Contributor

I took another look. This file is specifically for older versions of SSSD. The text in the related plugin mentions 1.5-1.8 https://github.com/freeipa/freeipa/blob/master/ipaserver/advise/plugins/legacy_clients.py#L97

I think it may be safe to leave this alone, though the longer this plugin exists the longer the meaning of legacy changes.

@alexey-tikhonov
Copy link
Contributor Author

I think it may be safe to leave this alone

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ipa-4-11 Mark for backport to ipa 4.11
Projects
None yet
Milestone
No milestone
3 participants
@alexey-tikhonov @rcritten @freeipa-pr-ci