Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipa-nis-manage as we aim to disable NIS server support #7336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abbra
Copy link
Contributor

@abbra abbra commented Apr 29, 2024

RHEL 8.3+ already deprecated support for NIS protocol.
RHEL 9 does not ship NIS client side
RHEL 10 removes NIS server emulator support

Fixes: https://pagure.io/freeipa/issue/9363

@abbra abbra added the ipa-next Mark as master (4.12) only label Apr 29, 2024
@abbra abbra force-pushed the nis-server-remove branch 2 times, most recently from a0b5e0b to d1fe1a6 Compare April 29, 2024 08:45
@abbra
Copy link
Contributor Author

abbra commented Apr 29, 2024

FYI, slapi-nis change that makes NIS server build optional is https://pagure.io/slapi-nis/c/446b64425c8db462d48ff651be15e5a00706f719?branch=master. I am planning to push that to Fedora rawhide next week.

@abbra abbra added the needs review Pull Request is waiting for a review label Apr 29, 2024
  RHEL 8.3+ already deprecated support for NIS protocol.
  RHEL 9 does not ship NIS client side
  RHEL 10 removes NIS server emulator support

Fixes: https://pagure.io/freeipa/issue/9363

Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
@rcritten
Copy link
Contributor

Do we want a test for the new "The NIS plugin is configured, cannot disable compatibility" scenario?

So it looks like if an install has NIS enabled this won't touch that. This is about preventing future enablement.

Do we want/need a tool to eventually disable NIS altogether? What happens if slapi-nis disables NIS support and slapi-nis is enabled in IPA? I assume lookups will stop functioning? Is there a way we can alert users? A healthcheck maybe?

@rcritten
Copy link
Contributor

rcritten commented May 9, 2024

The warning related to ipa-compat-manage disable works correctly but it makes me wonder.

When slapi-nis stops shipping the shared library will cause 389-ds to fail:

ERR - symload_report_error - Could not open library "/usr/lib64/dirsrv/plugins/nisserver-plugin.so" for plugin NIS Server

dsconf requires a running server so it won't be able to disable the plugin. Something, slapi-nis I presume, will need to disable this plugin on upgrade. Since the 389 config is an ldif perhaps the ldif module can parse, disable, then save the config.

Note that it the NIS plugin doesn't even need to be enabled to cause 389-ds to fail to start if the plugin is not present. The plugin config needs to be removed completely.

@abbra
Copy link
Contributor Author

abbra commented May 10, 2024

Thanks. Yes, Thierry told me the same but I haven't had time to look into this to fix.
Regarding 'slapi-nis disables NIS support and slapi-nis is enabled in IPA' case, this is what slapi-nis supposed to handle in its spec file but I didn't finish fixing that script yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ipa-next Mark as master (4.12) only needs review Pull Request is waiting for a review
Projects
None yet
2 participants