batch: Do not fail on missing attribute principal in error case #7332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-woerner
added
ipa-4-10
t-woerner
force-pushed
the
batch_fix_missing_attribute_principal
branch
from
b53885e
to
c339717
Compare
|
@t-woerner could you file an issue ticket? https://pagure.io/freeipa/new_issue, and add "Fixes:" in the commit message? |
context.principal is used for the info log in the error case of the execution of the commands. But this attribute does not seem to be set in all cases, which results in a trace in the error handling. Therefore the execution is aborted and real failure is not returned. Fixes: https://pagure.io/freeipa/issue/9583 Signed-off-by: Thomas Woerner <twoerner@redhat.com>
t-woerner
force-pushed
the
batch_fix_missing_attribute_principal
branch
from
c339717
to
bc45e6b
Compare
Here is the ticket: https://pagure.io/freeipa/issue/9583 |
|
This is superseded by #7335 right? |
varunmylaraiah
requested review from
varunmylaraiah
and removed request for
varunmylaraiah
Yes, I am closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.principal is used for the info log in the error case of the execution of the commands. But this attribute does not seem to be set in all cases, which results in a trace in the error handling. Therefore the execution is aborted and real failure is not returned.
Fixes: https://pagure.io/freeipa/issue/9583