Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipatests: Update ipa-adtrust-install test #7324

Closed
wants to merge 1 commit into from
Closed

ipatests: Update ipa-adtrust-install test #7324

wants to merge 1 commit into from

Conversation

b3lix
Copy link
Contributor

@b3lix b3lix commented Apr 11, 2024

update after change in implementation of krb_utils.get_principal() now using GSSAPI

Related: https://pagure.io/freeipa/issue/9575

@b3lix b3lix added trivial needs review Pull Request is waiting for a review tests Pull Request related to ipatests labels Apr 11, 2024
@b3lix b3lix requested a review from miskopo April 11, 2024 15:46
@b3lix b3lix self-assigned this Apr 11, 2024
@miskopo
Copy link
Member

miskopo commented Apr 30, 2024

@b3lix sir, I will have to ask you to include the proper temp commit in order to actually run the tests. Thank you!

@miskopo
Copy link
Member

miskopo commented May 2, 2024

From the temp commit:

DEBUG    ipatests.pytest_ipa.integration.host.Host.master.cmd242:transport.py:557 Must have Kerberos credentials to setup AD trusts on server: Major (458752): No credentials were supplied, or the credentials were unavailable or inaccessible, Minor (2529639053): No Kerberos credentials available (default cache: KCM:)

Please, remove the temp commit and I will ACK this PR.

@miskopo
Copy link
Member

miskopo commented May 2, 2024

Any backports required?

@b3lix b3lix added ipa-4-9 Mark for backport to ipa 4.9 ipa-4-10 Mark for backport to ipa 4.10 labels May 20, 2024
@b3lix b3lix force-pushed the update_test_adtrust_install_with_incorrect_admin_password branch from 4f9c902 to 397a089 Compare May 20, 2024 11:08
@b3lix
Copy link
Contributor Author

b3lix commented May 20, 2024

temp commit

@b3lix b3lix removed the needs review Pull Request is waiting for a review label May 20, 2024
@b3lix
ipatests: Update ipa-adtrust-install test
2d51559 
update after change in implementation of `krb_utils.get_principal()` now using GSSAPI

Related: https://pagure.io/freeipa/issue/9575

Signed-off-by: Erik Belko <ebelko@redhat.com>
@b3lix b3lix force-pushed the update_test_adtrust_install_with_incorrect_admin_password branch from 397a089 to 2d51559 Compare May 20, 2024 12:04
@miskopo miskopo added ack Pull Request approved, can be merged ipa-4-11 Mark for backport to ipa 4.11 labels May 21, 2024
@antoniotorresm antoniotorresm added the pushed Pull Request has already been pushed label May 21, 2024
@antoniotorresm
Copy link
Contributor

master:

  • 47920e7 ipatests: Update ipa-adtrust-install test

This was referenced May 21, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miskopo miskopo Awaiting requested review from miskopo

Assignees

@b3lix b3lix

Labels
ack Pull Request approved, can be merged ipa-4-9 Mark for backport to ipa 4.9 ipa-4-10 Mark for backport to ipa 4.10 ipa-4-11 Mark for backport to ipa 4.11 pushed Pull Request has already been pushed tests Pull Request related to ipatests trivial
Projects
None yet
Milestone
No milestone
3 participants
@b3lix @miskopo @antoniotorresm