idviews: Use ipaAnchorUUID without DCERPC bindings for SID anchors #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbra
reviewed
Feb 26, 2024
t-woerner
force-pushed
the
use_ipaAnchorUUID_on_replica_without_DCERPC_bindings_for_sid_anchors
branch
3 times, most recently
from
dacadf0
to
d91f579
Compare
abbra
reviewed
Feb 26, 2024
t-woerner
force-pushed
the
use_ipaAnchorUUID_on_replica_without_DCERPC_bindings_for_sid_anchors
branch
from
d91f579
to
b294051
Compare
|
The code LGTM. @t-woerner does it help with your reproducer? I wonder if we should turn that one into a test or rely on ansible-freeipa testing this scenario... |
|
Yes, this fixes the issue for me. |
SID anchors are only resolvable on servers with DCERPC bindings installed. On non agent replica these bindings are not installed and therefore group and role management if there are AD user idoverride members. If there is an ipaUserOverride for the anchor, the ipaoriginaluid is returned. Fixes: https://pagure.io/freeipa/issue/9544 Signed-off-by: Thomas Woerner <twoerner@redhat.com>
t-woerner
force-pushed
the
use_ipaAnchorUUID_on_replica_without_DCERPC_bindings_for_sid_anchors
branch
from
b294051
to
71e5d28
Compare
abbra
added
ack
|
We can add a test later. |
|
master:
|
This was referenced May 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SID anchors are only resolvable on servers with DCERPC bindings installed. On non agent replica these bindings are not installed and therefore group and role management if there are AD user idoverride members.
Fixes: https://pagure.io/freeipa/issue/9544