ipatests: Test ipaIdpSub attribute #7113
Conversation
miskopo
added
ipa-4-9
Test case to check if ipaIdpSub is correctly created for IdP and non-IdP users Related: https://pagure.io/freeipa/issue/9433 Signed-off-by: Michal Polovka <mpolovka@redhat.com>
Signed-off-by: Michal Polovka <mpolovka@redhat.com>
| extra_args=["--user-auth-type=idp", | ||
| "--idp-user-id=testuser1@ipa.test", | ||
| "--idp=testidp"]) | ||
| tasks.user_add(self.master, standard_user) |
There was a problem hiding this comment.
The test is adding idpuser but doesn't check anything on the output. Is this test useful, it seems redundant with the xmlrpc test in
freeipa/ipatests/test_xmlrpc/test_user_plugin.py
Lines 822 to 827 in 25b58e6
| cmd = ["ipa", "user-mod", standard_user, | ||
| "--idp-user-id=new.mydomain.test"] | ||
| list_user = self.master.run_command(cmd).stdout_text | ||
| assert "External IdP user identifier: new.mydomain.test" in list_user |
There was a problem hiding this comment.
This test looks redundant with the xmlrpc test in
freeipa/ipatests/test_xmlrpc/test_user_plugin.py
Lines 574 to 581 in 25b58e6
| list_user = self.master.run_command(cmd).stdout_text | ||
| assert "External IdP user identifier: new.mydomain.test" in list_user | ||
|
|
||
| # remove IdP and change idp-user-id for IdP user |
There was a problem hiding this comment.
This is actually the real meat: if an external idp is removed, any reference to this idp should be removed from user entries thanks to the referential integrity plugin.
But I don't think that it will remove the "idp" auth type from the user entry.
| assert "External IdP user identifier: new.mydomain.test" in list_user | ||
|
|
||
| # remove IdP and change idp-user-id for IdP user | ||
| cmd = ["ipa", "idp-del", "keycloak"] |
There was a problem hiding this comment.
based on line 330, the name should be testidp, not keycloak
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Test case to check if ipaIdpSub is correctly created
for IdP and non-IdP users
Related: https://pagure.io/freeipa/issue/9433
Signed-off-by: Michal Polovka mpolovka@redhat.com