Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some safety alerts #7157

Merged
merged 1 commit into from May 1, 2024
Merged

Ignore some safety alerts #7157

merged 1 commit into from May 1, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Apr 30, 2024

Status

Ready for review

Description of Changes

  • 66700 (CVE-2024-0690) - we only use no_log in tor-hidden-services where it is not in a loop
  • 66777 (CVE-2023-6237) - not affected, as we build against system OpenSSL
  • 66704 (CVE-2024-26130) - we should not be checking PKCS#12 keys/certs
  • 66710 (CVE-2023-29483) - dev only, DoS isn't an issue

Testing

  • visual review
  • CI passes

Deployment

Any special considerations for deployment? n/a

* 66700 (CVE-2024-0690) - we only use `no_log` in tor-hidden-services
  where it is not in a loop
* 66777 (CVE-2023-6237) - not affected, as we build against system
  OpenSSL
* 66704 (CVE-2024-26130) - we should not be checking PKCS#12 keys/certs
* 66710 (CVE-2023-29483) - dev only, DoS isn't an issue
@legoktm legoktm requested a review from a team as a code owner April 30, 2024 21:30
@cfm cfm self-assigned this May 1, 2024
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes now that #7155 (whose #7156 is blocked on this) does not apply.

@cfm cfm merged commit 33cb6eb into develop May 1, 2024
17 checks passed
@legoktm legoktm deleted the ignore-safety branch May 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants