New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(check-desktop-strings
): order, logging, Focal/bullseye compatibility
#7008
Conversation
…t 0.21 behavior Fixes #7007. Beginning in gettext 0.21---specifically, as of autotools-mirror/gettext@1c9b721---xgettext and (of interest to us) msgfmt do not localize the "Icon" keyword. That's fine, indeed preferable, for our purposes. But since Ubuntu Focal only has gettext 0.19, where they do, we need to pass an explicit "--keyword=Name" here to get consistent output across platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test plan checks out, so LGTM. Not merging in case you want to do #7007 (comment) and fold that into this PR. (But if that's separate/merits further discussion, that's fine too IMO).
…passing This partially reverts commit d4f47e1.
We've gone back and forth enough already that I might as well include it here. :-) Let me know what you think of 60f8afb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks :) Will merge once CI passes!
Status
Ready for review
Description of Changes
check-desktop-files
always fails in CircleCI. #7007, by enforcing forwards compatibility of Ubuntu Focal's gettext 0.19.8 with Debian bullseye's gettext 0.21, plus cosmetic changes contributed by @zenmonkeykstop.securedrop/desktop
to pass CI.Testing
CI
lint
should, indeed, pass for the translations indevelop
after Translations update from Weblate #6984.Optional: Locally confirm the expected behavior for current translations:
Optional: Locally confirm the expected behavior on future translations:
Deployment
Tooling-only; no deployment considerations.