redwood: Relax requirements for decrypting messages #7000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
commented
Oct 12, 2023
legoktm
force-pushed
the
sequoia-decryption
branch
from
b423ef4
to
4885140
Compare
Even if a source key is no longer valid per policy, we still want them to be able to decrypt a previously valid message for them. We can also drop the revocation/expiry filters, which were mostly theoretical in the SecureDrop context anyways. We first try validating the key with the StandardPolicy before trying again with a NullPolicy to avoid downgrade attacks. Since we now have another type of policy being used, the constant has been renamed to STANDARD_POLICY to be clearer what kind it is. Fixes #6991.
legoktm
force-pushed
the
sequoia-decryption
branch
from
4885140
to
3596bb0
Compare
|
(Rebased) |
zenmonkeykstop
approved these changes
Oct 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Even if a source key is no longer valid per policy, we still want them to be able to decrypt a previously valid message for them. We can also drop the revocation/expiry filters, which were mostly theoretical in the SecureDrop context anyways.
Fixes #6991.
Testing
Deployment
Any special considerations for deployment? No
Checklist
make lint) and tests (make test) pass in the development container