Assorted redwood/Sequoia fixes from Neal's review #6998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
force-pushed
the
sequoia-fixes
branch
2 times, most recently
from
10a6822
to
ebbcefe
Compare
|
The changes look good to me! |
First, use "create_new" mode when opening the file so if it already exists, an error will be raised instead of silently truncating the existing file. This required adjusting our tests a bit since NamedTempFile creates a file before we try writing to it. Then use a BufWriter to buffer filesystem writes instead of writing each byte as it comes in. Fixes #6989. Fixes #6990.
We were not checking if any subkeys had secret key material too, which is_tsk() checks for us. Fixes #6988.
legoktm
force-pushed
the
sequoia-fixes
branch
from
ebbcefe
to
814a37c
Compare
zenmonkeykstop
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
CI is passing, external review/approval provided via @nwalfield, visual review looks good! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
See individual commit messages for specific details:
Thank you @nwalfield for the review :) This fixes all of the raised issues that I considered to be 2.7.0 blockers
except #6986, which I needed more input on.Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? No
Checklist
make lint) and tests (make test) pass in the development container