Try GitHub Actions by migrating updater-gui-tests and rust jobs #6732
Conversation
|
One weird thing is that GH Actions will now run the job twice, once for the branch push inside the securedrop repo, and then again for the pull request. For quick jobs like this it's not an issue, but it could get annoying for longer ones. |
|
I too have noticed the double run (without taking action on it for my repos). Additionally, note that if tou want to (re-)trigger workflows manually for whatever reason, they must be configured to trigger on the |
When I visit https://github.com/freedomofpress/securedrop/actions/runs/3971850268/jobs/6809178862 I see a "Re-run all jobs", did you mean something different? |
|
Nope, if tou see the buttons, that was it. For some reason I had to enable that manually in my workflows... and found that explanation in GitHub's Help pages. |
legoktm
changed the title
The syntax is fairly close, so no actual changes were needed to the commands that are run. I did switch usage of `apt` to `apt-get` since the former isn't supposed to be used in scripts. I intentionally chose to not migrate the branch filter over to reduce complexity given how fast and light this job is.
|
Moving back to draft state, this needs to be updated and reconciled with #6969. (Maybe squashed into that PR?) |
|
I'm redoing these commits in #6969. |
Status
Ready for review
Description of Changes
Try GitHub Actions by migrating updater-gui-tests and rust jobs
The syntax is fairly close, so no actual changes were needed to the commands that are run.
I did switch usage of
apttoapt-getsince the former isn't supposed to be used in scripts.I intentionally chose to not migrate the branch filter over to reduce complexity given how fast and light this job is.
Testing
Deployment
Any special considerations for deployment? No.
Checklist
n/a