Source Interface: Flow Inversion #6438
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
force-pushed
the
6211-flow-inversion
branch
12 times, most recently
from
4cab80e
to
6e5cb05
Compare
zenmonkeykstop
force-pushed
the
6211-flow-inversion
branch
2 times, most recently
from
30aaae8
to
9e06c68
Compare
Towards #6211 Up until now, SecureDrop had an implicit "sign up" flow, in which sources were assigned a codename/passphrase before they were able to submit any messages/documents. This created a couple of technical pitfalls with regards to session management and (potentially) usability issues as well (user research pending). As sources were asked to write down their codenames/passphrases before they were able to do for what they came to the instance for, we made sure to remind them of their codename repeatedly. Flow inversion seeks to simplify both the backend implementation as well as the source interface's user experience.
Plus some cleanup
Needs discussion: is there a reason to keep the show codename button around? If so, we want to track it's state for the session so as to not confuse sources on page refreshes.
More optimisation wrt message validation vs. when to actually create a new source account, and start replacing codename with passphrase terminology
- updated interface strings - for consistency, updated CSS names as well - updated session key name
zenmonkeykstop
force-pushed
the
6211-flow-inversion
branch
from
9e06c68
to
8440b53
Compare
|
(Rebased as the auto-rebase in CI was breaking tests due to pageslayout changes introduced elsewhere.) |
nabla-c0d3
reviewed
Jun 21, 2022
| @@ -30,7 +30,7 @@ class SessionManager: | |||
| """Helper to manage the user's session cookie accessible via flask.session.""" | |||
|
|
|||
| # The keys in flask.session for the user's passphrase and expiration date | |||
| _SESSION_COOKIE_KEY_FOR_CODENAME = "codename" | |||
| _SESSION_COOKIE_KEY_FOR_CODENAME = "passphrase" | |||
There was a problem hiding this comment.
Should be _SESSION_COOKIE_KEY_FOR_PASSPHRASE here. Nice rename btw 👍
There was a problem hiding this comment.
Turns out the only thing in computer science more annoying than naming things is renaming them :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Up until now, SecureDrop had an implicit "sign up" flow, in which
sources were assigned a codename/passphrase before they were able to
submit any messages/documents.
This created a couple of technical pitfalls with regards to session
management and (potentially) usability issues as well (user research
pending). As sources were asked to write down their
codenames/passphrases before they were able to do for what
they came to the instance for, we made sure to remind them of their
codename repeatedly.
Flow inversion seeks to simplify both the backend implementation as well
as the source interface's user experience.
Towards #6211
Testing
TBD
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development container