Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cryptography to 3.4.7 in dev reqs too #5975

Merged
merged 1 commit into from Jun 10, 2021

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Jun 7, 2021

Status

Ready for review

Description of Changes

This updates cryptography to 3.4.7 in the development requirements too.

Testing

  • CI is green.
  • make venv produces a virtualenv containing cryptography 3.4.7.
  • The fpf-www-projects safety checks stop warning about the use of cryptography 3.2.1.

Deployment

Dev only.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a code dependency:

Choose one of the following:

@rmol rmol requested a review from a team as a code owner June 7, 2021 15:13
@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Jun 7, 2021
@rmol rmol added the blocked label Jun 7, 2021
@rmol
Copy link
Contributor Author

rmol commented Jun 7, 2021

To get past the lint error, this will need to be rebased after #5977 is merged.

@rmol rmol force-pushed the update-dev-cryptography branch from 1d2cfbb to d1b3771 Compare June 9, 2021 14:22
@rmol rmol removed the blocked label Jun 9, 2021
@eloquence eloquence added this to the 2.1.0 milestone Jun 9, 2021
@kushaldas kushaldas self-assigned this Jun 10, 2021
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha256sum matched.

@kushaldas kushaldas merged commit d196df0 into develop Jun 10, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done Jun 10, 2021
@kushaldas kushaldas deleted the update-dev-cryptography branch June 10, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants