Do not create local copy of backup file before extracting Tor config

[eloquence]

Status

Ready for review

Description of Changes

Fixes #5918

Testing

Estimated testing time: ~30-60 minutes (depending on any errors encountered)

Using a VM or production server environment, from your Admin Workstation:

1. Observe that you can reproduce Backup script copies entire backup file into memory #5918 on 1.8.1 by following the steps to reproduce
2. Observe that you can no longer reproduce Backup script copies entire backup file into memory #5918 with the changes in this branch in place (you will have to specify --force to run securedrop-admin commands directly from this branch)

(I suggest cancelling the large file transfer to the server, assuming it successfully proceeds to that stage.)

Checklist

• Linting (make lint) and tests (make test) pass in the development container

[eloquence]

For .tar.gz files, the unarchive module appears to expect full paths and will fail (misleadingly) with "Failed to find handler" on relative paths; see ansible/ansible#35645. The "Failed to find handler" issue arises only if we enable the remote_src setting, which suggests to me that otherwise, Ansible may pass along the full path to the copy it has created.

[eloquence]

app-tests CI failure is due to Xenial's end-of-life (#5920); Focal app tests are passing and app code has not been modified anyway. I could rebase onto cancel_xenial and convert to draft, but cancel_xenial is currently running behind develop and missing the v2 removal changes, so I'll just wait for now.

[eloquence]

(Rebased to pick up #5911.)

[codecov-commenter]

Codecov Report

Merging #5919 (e040fed) into develop (0f6ae64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5919   +/-   ##
========================================
  Coverage    85.37%   85.37%           
========================================
  Files           53       53           
  Lines         3876     3876           
  Branches       480      480           
========================================
  Hits          3309     3309           
  Misses         455      455           
  Partials       112      112           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6ae64...e040fed. Read the comment docs.

[rmol]

👍 Works great.