Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 30 day retention period for apache logs #3714

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

starchy
Copy link

@starchy starchy commented Aug 16, 2018

Status

Ready for review / Work in progress

Description of Changes

Fixes #304.

Changes proposed in this pull request:

Testing

How should the reviewer test this PR?
Write out any special testing steps here.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@zenmonkeykstop
Copy link
Contributor

Hi @starchy - this PR will probably need a rebase before review and merge. Do you have cycles available for it, or would you be OK with somebody else picking it up?

@starchy
Copy link
Author

starchy commented Jun 10, 2019 via email

@eloquence
Copy link
Member

eloquence commented Jun 11, 2020

Hi @starchy, sorry for the long silence on this PR. We're still interested in landing this change. There are no concerns in principle about reducing the retention from the perspective of tech support for newsrooms, though we may want to give organizations a heads up that this is coming.

Because this requires a run of the Ansible playbook to be applied to all configurations, one option we're considering is to fold this change into the release which will add support for the next LTS release of Ubuntu, where a playbook run will be required. This would ensure that we avoid too much configuration drift between new installs and existing ones. So just a heads up that this PR may remain open quite a bit longer (the current LTS reaches end-of-life on April 30, 2021).

@cfm
Copy link
Member

cfm commented Jan 9, 2023

It looks like we missed this pull request as part of the Xenial-to-Focal migration. @zenmonkeykstop (CC: @eloquence), is this something you'd be interested in pulling into either v2.6.1 or v2.7.0? Re: configuration drift, we could tack on a postinst fixup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default apache logrotate config
4 participants