Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

Add delete_conversation #158

Merged
merged 1 commit into from Jun 22, 2021
Merged

Add delete_conversation #158

merged 1 commit into from Jun 22, 2021

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Jun 14, 2021

Add support for the new endpoint allowing deletion of the entire conversation with a source.

@sssoleileraaa
Copy link
Contributor

test-against-latest-api failed on CircleCI - in case you didn't see it, https://github.com/freedomofpress/securedrop-sdk#creating-and-updating-tests has precise instructions on cassette generation for both http and over qrexec

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @rmol :) tested via freedomofpress/securedrop-client#1263 and also tested a bad UUID for the source to see the expected uiud error is thrown and handled in the client pr

@sssoleileraaa sssoleileraaa merged commit 0b2b69b into main Jun 22, 2021
@sssoleileraaa sssoleileraaa deleted the delete-conversation branch June 22, 2021 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants