Documents simpler upgrade testing workflow #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested changes
Jun 8, 2021
docs/development/upgrade_testing.rst
Outdated
| You can use this scenario to test the upgrade process, using using either | ||
| locally-built .debs or packages from the FPF test repo at | ||
| https://apt-test.freedom.press/. Both options are described below. | ||
| The Molecule upgrade scenario sets up local apt server, to imitate |
There was a problem hiding this comment.
nit: "sets up a local apt server"
docs/development/upgrade_testing.rst
Outdated
| https://apt-test.freedom.press/. Both options are described below. | ||
| The Molecule upgrade scenario sets up local apt server, to imitate | ||
| how new package versions will be installed in production. You'll need | ||
| to a virtualized Admin Workstation to configure the base server VMs |
There was a problem hiding this comment.
nit: "you'll need to use a virtualized"
Tracks changes in the provisioning/testing logic: * Removes maintenance of the custom VM images * Uses Molecule to manage prod VMs * Removes use of `vagrant` (prefer `molecule`)
conorsch
force-pushed
the
refresh-upgrade-testing
branch
from
0e768a5
to
d66fa2d
Compare
|
Thanks for the close read! Both comments now addressed. |
zenmonkeykstop
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Tracks changes in the provisioning/testing logic:
vagrant(prefermolecule)Should be reviewed in tandem with freedomofpress/securedrop#5960, see test plan over there.
Testing
Consult test plan in freedomofpress/securedrop#5960
Release
Dev-only.
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000