Fix of the failure to report shlib-to-shlib missing dependencies for 'pkg check -B' #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged thanks |
|
@bapt Do you know why this patch still isn't in 1.4.12 (released Feb 14), and also not in master branch? |
|
yes it was in master and I removed it, because of too many false positive, it does not have yet the full plist yet at this moment and fails to find lib it will provide, I was about to report you a feed back. I had to temporary revert it I was about to write you a feedback :) |
|
Could you provide an example of false positive, please? |
|
I'll write soon a unit test so you could be able to see them and probably fix :) will happen next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-posting the patch that went unanswered: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192606