-
Notifications
You must be signed in to change notification settings - Fork 123
Conversation
link:https://wiki.freebsd.org/MicrosoftAzure[Microsoft Azure article on FreeBSD wiki] URL: link:https://wiki.freebsd.org/MicrosoftAzure[] + | ||
link:https://wiki.freebsd.org/HyperV[Microsoft HyperV article on FreeBSD wiki] URL: link:https://wiki.freebsd.org/HyperV[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL: link:https://wiki.freebsd.org/MicrosoftAzure[https://wiki.freebsd.org/MicrosoftAzure]
and likewise for the next one.
2022q4/azure.adoc
Outdated
|
||
* Automating the image building and publishing process and merge to src/release/. | ||
* Building and publishing ZFS-based images to Azure Marketplace | ||
** All the requirted codes are merged to main branch, and can create ZFS-bared image by specifying `VMFS=zfs`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/requirted/required/
What does "ZFS-bared" mean?
s/image/images/, I think.
2022q4/azure.adoc
Outdated
* Automating the image building and publishing process and merge to src/release/. | ||
* Building and publishing ZFS-based images to Azure Marketplace | ||
** All the requirted codes are merged to main branch, and can create ZFS-bared image by specifying `VMFS=zfs`. | ||
** Need to make the build process more automaitc and collaborating with release engineering to start generating snapshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/automaitc/automatic/
|
||
Open tasks: | ||
|
||
* Update FreeBSD related doc at link:https://docs.microsoft.com[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link:https://docs.microsoft.com[https://docs.microsoft.com]
(or more explicit link if there's a specific subdir for FreeBSD)
I think repeat the same URL in the square brackets isn't very useful, and may even cause some editing error in the future. Just using the Also, I just found that this seems what other files do. I am OK to add to this one, but I strongly suggest let's remove to a simpler syntax, in this, or at least the next quarter. |
If I understand correctly, the repetition is currently to add links to the mail version: |
From https://github.com/freebsd/freebsd-quarterly#readme, with emphasis:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NTS: fill in empty []s.
Apologies, didn't notice this policy change. BTW, force-push on feature branch is quite common and useful to keep the history (of the main branch) clean, this is widely used in many other pleases. Also the review feature of GitHub is improved to cope with it. Please seriously consider this. cc @lsalvadore |
The reviewing procces is mainly in @pauamma's and @grahamperrin's hands, so I think they should choose what works best for them about squashing and force-pushing. Personally, I have no preference. A few thoughts about the topic:
|
Thanks, all
I'm aware of the plea in https://github.com/freebsd/freebsd-quarterly/blob/main/README.adoc only because I helped to edit the file.
I don't know enough about Git to express a preference. If someone can point me to a case where a squash or force-push did cause difficulty, I might form a preference … |
No description provided.