Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable load of tpm driver with devd rule #166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nangirl
Copy link

@nangirl nangirl commented Mar 9, 2023

The devd rule comes from @tstruk proposal. The old rule was not working. This rule won't trigger if tpm driver was already loaded at boot.

@tstruk
Copy link
Contributor

tstruk commented Mar 9, 2023

Looks good to me. Thanks!

@bsdimp
Copy link
Member

bsdimp commented Mar 9, 2023

This will work, though devfs is usually used instead of devd to set ownership and permissions

@LuKePicci
Copy link

LuKePicci commented Mar 9, 2023

@bsdimp devfs doesn't fit well to the "packaged" rule addition approach. AFAIK there's no way to include additional devfs rules by adding a file. The only devfs way would be to define such rule into something which is not part of this package. Does the _tss group exist before installing this port? Would it be fine to have devfs setting permissions to a non-existing group id?

BTW, I made a quick test on pfSense with devfs.rules by setting a new system default ruleset and extending the previous default ruleset with a new extra rule for tpm. It didn't work until I restarted devfs despite tpm.ko was correctly loaded during boot with tpm_load="YES". Not sure if pfSense is doing strange things with devfs or this tpm driver couldn't work with devfs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants