2024Q1: Add cloud-init quarterly report #369
Conversation
|
|
||
| - I have written a small https://codeberg.org/meena/test-cloud-init[testing-framework] (in sh, and I'm slowly porting it to OpenTofu/Terraform), which installs the latest version of package:net/cloud-init-devel[] or package:net/cloud-init[] and runs a couple of standard cloud-init tests. | ||
| - To do this, I have created a https://pkg.igalic.co/[dedicated public repository] which contains the latest versions of package:net/cloud-init-devel[] and package:net/cloud-init[] for FreeBSD 13 and 14 on amd64 and aarch64 | ||
| - I have ported Linux' vsock testing framework to https://codeberg.org/meena/vsock-tests[FreeBSD] |
There was a problem hiding this comment.
I'd move some of the surrounding text into the link text, for better readability when links are shown separate. Something like:
- I have https://codeberg.org/meena/vsock-tests[ported Linux' vsock testing framework to FreeBSD]
There was a problem hiding this comment.
I am not a native English speaker so I might be wrong, but I am not used to see apostrophes at the end of words ending in x. Is Linux' vsock testing framework correct? Shouldn't it be Linux vsock testing framework or Linux's vsock testing framework? Is there some rule saying that words ending in x act as words finishing in s?
There was a problem hiding this comment.
fixed, honestly don't know where I learned that.
| - I have written a small https://codeberg.org/meena/test-cloud-init[testing-framework] (in sh, and I'm slowly porting it to OpenTofu/Terraform), which installs the latest version of package:net/cloud-init-devel[] or package:net/cloud-init[] and runs a couple of standard cloud-init tests. | ||
| - To do this, I have created a https://pkg.igalic.co/[dedicated public repository] which contains the latest versions of package:net/cloud-init-devel[] and package:net/cloud-init[] for FreeBSD 13 and 14 on amd64 and aarch64 | ||
| - I have ported Linux' vsock testing framework to https://codeberg.org/meena/vsock-tests[FreeBSD] | ||
| - Created the baseline of a https://codeberg.org/meena/freebsd-src/src/branch/vsock/sys/dev/virtio/socket[VirtIO Socket driver], based on the HyperV Socket driver. |
There was a problem hiding this comment.
s/Created/I created/ maybe, for consistency with other bullet points.
Also, can you clarify what you mean by "baseline" here?
There was a problem hiding this comment.
An alternative which would work in case you are not the author of this baseline is "A baseline has been created".
| - In doing so, I made numerous https://reviews.freebsd.org/D44517[improvements to HyperV sockets], some of which are accepted, others still need more work. | ||
| - I have tested and released the latest 24.1 series cloud-init, where we have finally fixed some longstanding bugs, such as [moving ``/run/cloud-init``]https://github.com/canonical/cloud-init/pull/4820 to ``/var/run/cloud-init`` on BSD, as well as fixing the https://github.com/canonical/cloud-init/pull/5061[``homedir`` argument] to ``user_groups`` to actually do something. | ||
| - This release also sees numerous fixes to the OpenBSD code-paths from the community and not just me. | ||
| - I've also started an official port for OpenBSD, but that work https://marc.info/?l=openbsd-ports&m=170508174230708&w=2[has stalled]. |
There was a problem hiding this comment.
Similar to above, I'd move "that work" into the link text.
Current status as of Milestone 1 Sponsored by: The FreeBSD Foundation
igalic
force-pushed
the
add/2024Q1-cloud-init
branch
from
e65a6f8
to
d4a2b69
Compare
|
@pauamma thanks for the review; i updated the things as you suggested, and also found a mis-formated link ([text]link vs link[text]) |
There was a problem hiding this comment.
Thanks for your report, I have added a few comments.
Also, I find a bit confusing that you sometimes use the "I" pronoun while other times you use "we". Who is "we"? A cloud-init team? A team of FreeBSD contributors? You and the Foundation that sponsored you?
|
|
||
| - I have written a small https://codeberg.org/meena/test-cloud-init[testing-framework] (in sh, and I'm slowly porting it to OpenTofu/Terraform), which installs the latest version of package:net/cloud-init-devel[] or package:net/cloud-init[] and runs a couple of standard cloud-init tests. | ||
| - To do this, I have created a https://pkg.igalic.co/[dedicated public repository] which contains the latest versions of package:net/cloud-init-devel[] and package:net/cloud-init[] for FreeBSD 13 and 14 on amd64 and aarch64 | ||
| - I have ported Linux' vsock testing framework to https://codeberg.org/meena/vsock-tests[FreeBSD] |
There was a problem hiding this comment.
I am not a native English speaker so I might be wrong, but I am not used to see apostrophes at the end of words ending in x. Is Linux' vsock testing framework correct? Shouldn't it be Linux vsock testing framework or Linux's vsock testing framework? Is there some rule saying that words ending in x act as words finishing in s?
| - I have written a small https://codeberg.org/meena/test-cloud-init[testing-framework] (in sh, and I'm slowly porting it to OpenTofu/Terraform), which installs the latest version of package:net/cloud-init-devel[] or package:net/cloud-init[] and runs a couple of standard cloud-init tests. | ||
| - To do this, I have created a https://pkg.igalic.co/[dedicated public repository] which contains the latest versions of package:net/cloud-init-devel[] and package:net/cloud-init[] for FreeBSD 13 and 14 on amd64 and aarch64 | ||
| - I have ported Linux' vsock testing framework to https://codeberg.org/meena/vsock-tests[FreeBSD] | ||
| - Created the baseline of a https://codeberg.org/meena/freebsd-src/src/branch/vsock/sys/dev/virtio/socket[VirtIO Socket driver], based on the HyperV Socket driver. |
There was a problem hiding this comment.
An alternative which would work in case you are not the author of this baseline is "A baseline has been created".
| - I have ported Linux' vsock testing framework to https://codeberg.org/meena/vsock-tests[FreeBSD] | ||
| - Created the baseline of a https://codeberg.org/meena/freebsd-src/src/branch/vsock/sys/dev/virtio/socket[VirtIO Socket driver], based on the HyperV Socket driver. | ||
| - In doing so, I made numerous https://reviews.freebsd.org/D44517[improvements to HyperV sockets], some of which are accepted, others still need more work. | ||
| - I have tested and released the latest 24.1 series cloud-init, where we have finally fixed some longstanding bugs, such as [moving ``/run/cloud-init``]https://github.com/canonical/cloud-init/pull/4820 to ``/var/run/cloud-init`` on BSD, as well as fixing the https://github.com/canonical/cloud-init/pull/5061[``homedir`` argument] to ``user_groups`` to actually do something. |
There was a problem hiding this comment.
| - I have tested and released the latest 24.1 series cloud-init, where we have finally fixed some longstanding bugs, such as [moving ``/run/cloud-init``]https://github.com/canonical/cloud-init/pull/4820 to ``/var/run/cloud-init`` on BSD, as well as fixing the https://github.com/canonical/cloud-init/pull/5061[``homedir`` argument] to ``user_groups`` to actually do something. | |
| - I have tested and released the latest 24.1 series cloud-init, where we have finally fixed some longstanding bugs, such as link:https://github.com/canonical/cloud-init/pull/4820[moving ``/run/cloud-init``] to ``/var/run/cloud-init`` on BSD, as well as fixing the link:https://github.com/canonical/cloud-init/pull/5061[``homedir`` argument] to ``user_groups`` to actually do something. |
| - In doing so, I made numerous https://reviews.freebsd.org/D44517[improvements to HyperV sockets], some of which are accepted, others still need more work. | ||
| - I have tested and released the latest 24.1 series cloud-init, where we have finally fixed some longstanding bugs, such as [moving ``/run/cloud-init``]https://github.com/canonical/cloud-init/pull/4820 to ``/var/run/cloud-init`` on BSD, as well as fixing the https://github.com/canonical/cloud-init/pull/5061[``homedir`` argument] to ``user_groups`` to actually do something. | ||
| - This release also sees numerous fixes to the OpenBSD code-paths from the community and not just me. | ||
| - I've also started an official port for OpenBSD, but that work https://marc.info/?l=openbsd-ports&m=170508174230708&w=2[has stalled]. |
There was a problem hiding this comment.
Please avoid contractions.
| - I've also started an official port for OpenBSD, but that work https://marc.info/?l=openbsd-ports&m=170508174230708&w=2[has stalled]. | |
| - I have also started an official port for OpenBSD, but that work https://marc.info/?l=openbsd-ports&m=170508174230708&w=2[has stalled]. |
| - finish the FreeBSD VirtIO Socket driver | ||
| - fix Go's runtime to support VirtIO on FreeBSD | ||
| - port lxd-agent's dependencies to FreeBSD | ||
| - port lxd-agent to FreeBSD |
There was a problem hiding this comment.
Please be consistent with your lists: the first list has all elements starting with uppercase letters, this one has all elements starting with lowercase letters. Also the first list has all elements (except one) finishing with a period, while all the elements of this list end with no punctuation.
| Here are some improvements from the recent weeks: | ||
|
|
||
| - I have written a small https://codeberg.org/meena/test-cloud-init[testing-framework] (in sh, and I'm slowly porting it to OpenTofu/Terraform), which installs the latest version of package:net/cloud-init-devel[] or package:net/cloud-init[] and runs a couple of standard cloud-init tests. | ||
| - To do this, I have created a https://pkg.igalic.co/[dedicated public repository] which contains the latest versions of package:net/cloud-init-devel[] and package:net/cloud-init[] for FreeBSD 13 and 14 on amd64 and aarch64 |
There was a problem hiding this comment.
All elements of this list end with a period. I suggest adding one here as well.
| - To do this, I have created a https://pkg.igalic.co/[dedicated public repository] which contains the latest versions of package:net/cloud-init-devel[] and package:net/cloud-init[] for FreeBSD 13 and 14 on amd64 and aarch64 | |
| - To do this, I have created a https://pkg.igalic.co/[dedicated public repository] which contains the latest versions of package:net/cloud-init-devel[] and package:net/cloud-init[] for FreeBSD 13 and 14 on amd64 and aarch64. |
Reviewed by: status (Pau Amma <pauamma@gundo.com>) Pull Request: #369
|
Merged with a few final formatting edits that we missed earlier (I have added a few missing |
Current status as of Milestone 1