Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests on Basic JS array challenges #9881

Merged

Conversation

dhcodes
Copy link
Contributor

@dhcodes dhcodes commented Jul 25, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Per the issue #9806 I removed the .toLowerCase() from the unshift() challenge and made all array challenges use strict equality with doing number comparisons to prevent strings from passing as numbers. I tested these 4 challenges locally and the tests appear to be valid.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 25, 2016
@BKinahan
Copy link
Contributor

Travis is taking his sweet time, but I tested locally and each challenge runs as expected.

LGTM 👍

@dhcodes
Copy link
Contributor Author

dhcodes commented Jul 25, 2016

Even Travis deserves a coffee break @BKinahan

@ghost
Copy link

ghost commented Jul 25, 2016

LGTM 👍

Thank you for contributing to Free Code Camp 🎉

@ghost ghost merged commit 358c620 into freeCodeCamp:staging Jul 25, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 25, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants