Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo for computer basics question. #9675

Merged

Conversation

refinedblessing
Copy link
Contributor

@refinedblessing refinedblessing commented Jul 11, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

I corrected this question, this text and this other question from using bits to bits per second as a measure for data speed.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 11, 2016
@refinedblessing refinedblessing changed the title Correct text for computer basics question. Correct typo for computer basics question. Jul 11, 2016
@Bouncey
Copy link
Member

Bouncey commented Jul 11, 2016

LGTM 👍

Thanks for contributing 🎉

@Bouncey
Copy link
Member

Bouncey commented Jul 11, 2016

@andela-bebowe Can you please do the Spanish translation also? A google translate should be fine, as it is such a small adjustment.

Remember to git commit --amend so you don't end up with multiple commits.

@Bouncey Bouncey added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Jul 11, 2016
@camperbot
Copy link
Contributor

@andela-bebowe updated the pull request.

@Bouncey Bouncey merged commit 38400d5 into freeCodeCamp:staging Jul 11, 2016
@Bouncey
Copy link
Member

Bouncey commented Jul 11, 2016

Thank you @andela-bebowe 👍

@BerkeleyTrue BerkeleyTrue removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jul 11, 2016
@refinedblessing
Copy link
Contributor Author

I am very excited to have done this task its my first open source contribution, and I hope to do more. @Bouncey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants