Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Turn an Image into a Link Challenge #9435

Conversation

RyanWillDev
Copy link
Contributor

@RyanWillDev RyanWillDev commented Jun 28, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

I added the line (1637) 'Place the existing image element within an anchor element' to clarify the instructions of the challenge.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 28, 2016
@raisedadead raisedadead changed the title Added a line (1637) to html5-and-css.json to clarify instructions Fix Turn an Image into a Link Challenge Jun 28, 2016
@raisedadead
Copy link
Member

✨ ✨ SWEEEEEEEEET. ✨ ✨

Thanks @RyanWillDev ! And Congratulations for you first contribution to Free Code Camp and Open Source.

@raisedadead raisedadead merged commit 10d5f48 into freeCodeCamp:staging Jun 28, 2016
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 28, 2016
@RyanWillDev
Copy link
Contributor Author

Thanks @raisedadead. Hope I can help some more in the future.

@RyanWillDev RyanWillDev deleted the fix/add-anchor-wording-html5-and-css branch June 28, 2016 19:53
@raisedadead
Copy link
Member

@RyanWillDev Sure thing looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants