Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress and reduce redundant Hex/RGB challenges #8347

Conversation

erictleung
Copy link
Member

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Add new translation (feature adding new translations)

Checklist:

Description

Currently, the HTML challenges involving learning Hex codes and RGB were really long and redundant. I reduced the currently 15 challenges down to 5 challenges that I hope will still teach the same material. Feedback is welcome.

/cc: @SaintPeter

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 29, 2016
@SaintPeter
Copy link
Member

I went through this and it looks really great. It could totally be merged now and we'd be good, but I had a couple thoughts as I went through:

  1. It might make sense to mix up the order of the colors in the table in the instructions, just so it's not so obviously 1:1 with the order that they go into the challenges.
  2. It wouldn't hurt to mix up the colors a bit to go with some non-primaries. Dunno if that would be more confusing than useful, though.

@erictleung
Copy link
Member Author

@SaintPeter thanks for the feedback.

  1. Can do.
  2. Yeah, I felt that I could have varied the colors a bit. I think keeping (most of) the primary RGB colors would be good to illustrate the breakdown of the each color system (Hex and RGB) but adding more colors than that might be too tedious. So maybe have a total of four colors, two for a random subset of the primary colors and two other more mixed colors which change. I'll try some different things and see what fits.

I'll make updates and push them when I get the time.

@camperbot
Copy link
Contributor

@erictleung updated the pull request.

@erictleung erictleung force-pushed the fix/compress-and-reduce-redundant-css-hex-rgb branch from 01624ce to d28c8cb Compare May 9, 2016 05:07
@erictleung erictleung force-pushed the fix/compress-and-reduce-redundant-css-hex-rgb branch from d28c8cb to 91572bd Compare May 20, 2016 23:44
@camperbot
Copy link
Contributor

@erictleung updated the pull request.

@erictleung
Copy link
Member Author

@SaintPeter whenever you get a chance, can you take a look at this? I made the updates we talked about and used some different colors rather than all primary colors.

@SaintPeter SaintPeter merged commit c7532dd into freeCodeCamp:staging May 23, 2016
@SaintPeter SaintPeter removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 23, 2016
@SaintPeter
Copy link
Member

Perfect! Looks great.

@erictleung erictleung deleted the fix/compress-and-reduce-redundant-css-hex-rgb branch May 23, 2016 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants