Change italic method to em in Change Text jQuery #7823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change italic example from using i to em tag - Add spaces in editor for ease of code addition - Update tests to reflect em tag change
BerkeleyTrue
added
the
status: waiting review
| @@ -556,7 +556,7 @@ | |||
| "fccss", | |||
| " $(document).ready(function() {", | |||
| " $(\"#target1\").css(\"color\", \"red\");", | |||
| "", | |||
| " ", | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
lgtm 👍 |
justincorrigible
removed
the
status: waiting review
|
This also resolves #5425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally. Passes
npm run test-challenges. Closes #7512.