Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed-wording-for-step-5-of-pyramid-project #54735

Closed
wants to merge 2 commits into from
Closed

fixed-wording-for-step-5-of-pyramid-project #54735

wants to merge 2 commits into from

Conversation

adityarajshekhawat
Copy link
Contributor

Checklist:

Closes #54608

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-introductory-javascript-by-building-a-pyramid-generator/step-5

@camperbot
Copy link
Contributor

Thanks for your pull request.

Please remove the changes made to the non-English versions of the files. No need to close this pull request; just add more commits as needed.

We require you to change only English versions of files in the codebase. Translations to corresponding files in other world languages are managed on our translation platform. Once your pull request is merged, changes will be synced automatically to other world languages.

Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!

Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels May 10, 2024
jdwilkin4
jdwilkin4 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have changed the wrong file.
You should only update the english files.
Please re read through the issue to get the correct file you are supposed to change.

@jdwilkin4 jdwilkin4 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP new javascript course These are for issues dealing with the new JS curriculum labels May 10, 2024
@adityarajshekhawat
Copy link
Contributor Author

It looks like you have changed the wrong file. You should only update the english files. Please re read through the issue to get the correct file you are supposed to change.

okay i will do that

@camperbot
Copy link
Contributor

Thanks for your pull request.

Please remove the changes made to the non-English versions of the files. No need to close this pull request; just add more commits as needed.

We require you to change only English versions of files in the codebase. Translations to corresponding files in other world languages are managed on our translation platform. Once your pull request is merged, changes will be synced automatically to other world languages.

Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!

Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

ilenia-magoni
ilenia-magoni reviewed May 11, 2024
View reviewed changes
...22/learn-introductory-javascript-by-building-a-pyramid-generator/660ef31a5be625914a0102cd.md
@@ -14,7 +14,8 @@ let programmer = "Naomi";
programmer = "CamperChan";
```

Note that when reassigning a variable that has already been declared, you do **not** use the `let` keyword.
Note that when reassigning a variable, you do **not** use the `let` keyword again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Keep the empty lines consistent please

ilenia-magoni
ilenia-magoni requested changes May 11, 2024
View reviewed changes
...22/learn-introductory-javascript-by-building-a-pyramid-generator/660ef31a5be625914a0102cd.md
@@ -13,7 +13,6 @@ When a variable is declared with the `let` keyword, you can <dfn>reassign</dfn>
let programmer = "Naomi";
programmer = "CamperChan";
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the arabic file to the original condition

@Ksound22
Copy link
Member

Ksound22 commented May 13, 2024 •
edited

You should not make changes to translation files. That's why one of the CIs is failing

@adityarajshekhawat adityarajshekhawat deleted the fix/wording-for-step-5-of-pyramid-project branch May 13, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 left review comments

@ilenia-magoni ilenia-magoni ilenia-magoni requested changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update wording for step 5 of pyramid project
5 participants
@adityarajshekhawat @camperbot @Ksound22 @ilenia-magoni @jdwilkin4