New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert projects to Playwright #54689
feat: convert projects to Playwright #54689
Conversation
3eb4aef
to
f8f736f
Compare
It seems something weird is going on. When seeding development user in the test everything seems to work as intended in that particular test. This is not the case for other tests. Example the settings spec seems to receive development user instead of the certified user e.g.: Not only that, but in some cases the user is logged out entirely. Bummer. |
b795563
to
5c4edb8
Compare
I was able to make some progress (see 5c4edb8).
|
I'll try using the But maybe the last resort is setting up a new workflow that runs tests with the development user data (#52905 (comment)). |
@huyenltnguyen yep, it's the cookies. The issue is that the cookies for I'll create a quick PR for that, so you can use it here. |
#54752 should help. Once it's in, switching users means both changing storage state and seeding the desired user. |
I made some changes and cleaned up the tests a bit. The main changes are:
Notes for morning me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hookay, I think the PR is good to go.
This is one heck of a test suite to write / rewrite 😰
It works for both projects and normal lessons, so there's no need to handle them separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a struggle. Nice work, @Sembauke and @huyenltnguyen!
LGTM 👍
Checklist:
main
branch of freeCodeCamp.Closes #XXXXX