Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style stats component profile #54585

Closed

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Apr 30, 2024

Checklist:

This fixes a couple of things for the Stats components that were left out in the previous re-design:

  1. font-style is now Inter instead of Sans-serif
  2. font-weight is correct on the points
  3. font-size is now correct on all text
  4. The header is now placed on the left instead of centre
  5. Added the missing horizontal line above the stats component
  6. Removed semi-colons from points text

New:
image

Old:
image

Edit: it is missing the semi-colons as I did not clean the cache

Related to #48234

@Sembauke Sembauke requested a review from a team as a code owner April 30, 2024 12:42
@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 30, 2024
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Apr 30, 2024
@Sembauke
Copy link
Member Author

Seems like Ahmad has a pr open that fixes all the styles.

@Sembauke Sembauke closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant