Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): update text to include truthy value #54552

Closed
wants to merge 5 commits into from

Conversation

Supravisor
Copy link
Contributor

@Supravisor Supravisor commented Apr 27, 2024

Checklist:

Closes #54541

Description text only
image

Description and hint text
image

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Apr 27, 2024
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new javascript course These are for issues dealing with the new JS curriculum labels Apr 27, 2024
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this earlier.

The hint text should be updated too to say truthy so it is consistent.

@jdwilkin4 jdwilkin4 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Apr 27, 2024
@Supravisor Supravisor closed this Apr 29, 2024
@Supravisor
Copy link
Contributor Author

nn

@Supravisor Supravisor reopened this Apr 29, 2024
@camperbot
Copy link
Contributor

This PR seems to make similar changes as an existing PR. As such, we are going to close this as a duplicate.

If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.

Thanks again! 😊


If you have any questions, feel free to ask questions on the "Contributors" category on our forum or the contributors chat room.

@camperbot camperbot closed this Apr 29, 2024
@Supravisor Supravisor deleted the platformerGame38 branch April 29, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Fix test bug): Step 86 of "Building a Platformer Game"
3 participants