Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): step 86 of the platform game now requests an truthy value #54549

Merged
merged 2 commits into from Apr 29, 2024
Merged

fix(curriculum): step 86 of the platform game now requests an truthy value #54549

merged 2 commits into from Apr 29, 2024

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Apr 26, 2024

…value

Checklist:

Closes #54541

All that was requested was a simple word change.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Apr 26, 2024
jdwilkin4
jdwilkin4 reviewed Apr 27, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the description needs to be updated too

@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Apr 27, 2024
@a2937
Copy link
Member Author

a2937 commented Apr 27, 2024

There we go. Updated .

@jdwilkin4 jdwilkin4 added new javascript course These are for issues dealing with the new JS curriculum and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Apr 27, 2024
@Sembauke Sembauke merged commit f427701 into freeCodeCamp:main Apr 29, 2024
19 of 22 checks passed
@a2937 a2937 deleted the fix(curriculum)/use-is-truthy-platform-game-step-86 branch April 29, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sembauke Sembauke Sembauke approved these changes

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Fix test bug): Step 86 of "Building a Platformer Game"
3 participants
@a2937 @Sembauke @jdwilkin4