test: improve shortcuts modal spec #54544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope: tools/scripts
ojeytonwilliams
changed the title
naomi-lgbt
approved these changes
Apr 26, 2024
Sembauke
added
the
status: merge conflict
We're not testing the /settings UI here, so we can save time and not visit /settings
ojeytonwilliams
force-pushed
the
test/shortcuts-modal
branch
from
706fc6b
to
16fd4d4
Compare
ojeytonwilliams
added
status: waiting review
huyenltnguyen
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.I noticed on #54518 that this spec is flaky https://github.com/freeCodeCamp/freeCodeCamp/actions/runs/8845803793/job/24290758729
I'm not 100% confident this fixes that, but it is considerably faster and a bit tidier.
In general, we should be able to make the tests more performant if we only test the UI once in the spec that's concerned with that portion of the UI. When a spec needs the db to be in a particular state before starting, we should set that up via db calls or, preferably, api calls.