Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): Updated step 74 of spreadsheet project and added step 75 and step 76 #54417

Merged
merged 9 commits into from May 2, 2024
Merged

fix(curriculum): Updated step 74 of spreadsheet project and added step 75 and step 76 #54417

merged 9 commits into from May 2, 2024

Conversation

sanskriti2005
Copy link
Contributor

Checklist:

Closes #54327

@sanskriti2005 sanskriti2005 requested a review from a team as a code owner April 17, 2024 04:17
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 17, 2024
@sanskriti2005 sanskriti2005 changed the title Updated step74 of spreadsheet project and added step 75 and step 76 fix(curriculum): Updated step 74 of spreadsheet project and added step 75 and step 76 Apr 17, 2024
naomi-lgbt
naomi-lgbt requested changes Apr 17, 2024
View reviewed changes
...ctures-22/learn-functional-programming-by-building-a-spreadsheet/646d404259f512c1a9e86ac1.md Outdated Show resolved Hide resolved
...ctures-22/learn-functional-programming-by-building-a-spreadsheet/661f48f412d7631a1d9c30e6.md Outdated Show resolved Hide resolved
...ctures-22/learn-functional-programming-by-building-a-spreadsheet/661f48f412d7631a1d9c30e6.md Outdated Show resolved Hide resolved
...ctures-22/learn-functional-programming-by-building-a-spreadsheet/661f49650572031c6ebdb8e3.md Outdated Show resolved Hide resolved
...ctures-22/learn-functional-programming-by-building-a-spreadsheet/661f49650572031c6ebdb8e3.md Outdated Show resolved Hide resolved
...ctures-22/learn-functional-programming-by-building-a-spreadsheet/661f49650572031c6ebdb8e3.md Outdated Show resolved Hide resolved
...ctures-22/learn-functional-programming-by-building-a-spreadsheet/661f49650572031c6ebdb8e3.md Show resolved Hide resolved
@jdwilkin4 jdwilkin4 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP new javascript course These are for issues dealing with the new JS curriculum labels Apr 17, 2024
@sanskriti2005
Copy link
Contributor Author

sanskriti2005 commented Apr 18, 2024 •
edited

I will make the requested changes, thank you for the review.

@Sembauke Sembauke added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Apr 19, 2024
@sanskriti2005 sanskriti2005 force-pushed the update-step74-of-spreadsheet-project branch from 9270bd9 to 836f01d Compare April 19, 2024 11:03
@sanskriti2005
Copy link
Contributor Author

@Ksound22 thank you for the review :)

I will make the changes.

@jdwilkin4 jdwilkin4 requested a review from Ksound22 April 29, 2024 13:47
Ksound22
Ksound22 reviewed May 1, 2024
View reviewed changes
Copy link
Member

@Ksound22 Ksound22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@huyenltnguyen huyenltnguyen enabled auto-merge (squash) May 2, 2024 05:48
@huyenltnguyen huyenltnguyen merged commit 2495b0e into freeCodeCamp:main May 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@Ksound22 Ksound22 Ksound22 approved these changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update step 74 of spreadsheet project
6 participants
@sanskriti2005 @naomi-lgbt @Ksound22 @huyenltnguyen @Sembauke @jdwilkin4