New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(curriculum): add English curriculum block 8.2 updates and plans on tasks or projects #54332
Conversation
...learn-how-to-talk-about-updates-and-plans-for-tasks-and-projects/6613d00727a7a64a5e010243.md
Outdated
Show resolved
Hide resolved
...learn-how-to-talk-about-updates-and-plans-for-tasks-and-projects/6613d0773359964ab8812659.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't mind @miyaliu666, I pushed some minor fixes. Take a look at the diff to see what I changed, or let me know if you want me to show you.
This looks good. The only concern I had is that the first two task descriptions are the "Practice time" style. Do we want to start with two tasks that don't explain anything and just throw users into it? I'm fine with it, just mentioning it.
@naomi-lgbt I used "Fill in the blanks in the dialogue below" and "Please answer the question below" in Part 9 and 5 after I saw your comments here. I'll add explanations for words in the first two tasks as @moT01 pointed out. Those words have been taught in previous blocks, but we can review them here because people may not learn the blocks in strict order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Checklist:
main
branch of freeCodeCamp.