Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove component library as internal dependency #54322

Merged
merged 4 commits into from Apr 8, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Apr 8, 2024

  • test(client): remove component library as a internal package
  • fix: pnpm lock file

Checklist:

Closes #XXXXX

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Apr 8, 2024
@Sembauke Sembauke changed the title test: remove component library as internal dependency refactor: remove component library as internal dependency Apr 8, 2024
@Sembauke Sembauke marked this pull request as ready for review April 8, 2024 11:20
@Sembauke Sembauke requested a review from a team as a code owner April 8, 2024 11:20
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and confirmed that /learn is working and displaying things as expected.

@huyenltnguyen huyenltnguyen added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 8, 2024
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and I was able to claim a certificate so it doesn't seem like anything broke.

LGTM 👍

@Sembauke Sembauke merged commit 84b1a40 into freeCodeCamp:main Apr 8, 2024
23 checks passed
@Sembauke Sembauke deleted the test/remove-component-library branch April 8, 2024 17:35
jdwilkin4 pushed a commit to jdwilkin4/freeCodeCamp that referenced this pull request Apr 18, 2024
ahmaxed pushed a commit to ahmaxed/freeCodeCamp that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants