Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE - refactor(curriculum): refactoring RPG project to prepare for the addition of the intro JS project #54321

Closed
wants to merge 65 commits into from
Closed

DO NOT MERGE - refactor(curriculum): refactoring RPG project to prepare for the addition of the intro JS project #54321

wants to merge 65 commits into from

Conversation

jdwilkin4
Copy link
Contributor

@jdwilkin4 jdwilkin4 commented Apr 7, 2024 •
edited

Summary of changes

This PR updates the RPG project to prepare for the addition of the intro pyramid project that will go before this one

#54305

Checklist:

@jdwilkin4 jdwilkin4 added the new javascript course These are for issues dealing with the new JS curriculum label Apr 7, 2024
@jdwilkin4 jdwilkin4 self-assigned this Apr 7, 2024
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 7, 2024
@jdwilkin4 jdwilkin4 marked this pull request as ready for review April 9, 2024 15:46
@jdwilkin4 jdwilkin4 requested a review from a team as a code owner April 9, 2024 15:46
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 11, 2024
@raisedadead raisedadead marked this pull request as draft April 11, 2024 06:54
@raisedadead raisedadead changed the title refactor(curriculum): refactoring RPG project to prepare for the addition of the intro JS project DO NOT MERGE - refactor(curriculum): refactoring RPG project to prepare for the addition of the intro JS project Apr 11, 2024
@raisedadead
Copy link
Member

It is easy to miss a label :), I propose using drafts and a header in the PR title (which can be edited back later).

@jdwilkin4
Copy link
Contributor Author

TODO note for myself

Push up commit to change project name back to original

Ksound22
Ksound22 reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@Ksound22 Ksound22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions

...-22/learn-basic-dom-manipulation-by-building-a-role-playing-game/62a23cb9bc467a147516b500.md Outdated Show resolved Hide resolved
...-22/learn-basic-dom-manipulation-by-building-a-role-playing-game/62a23d1c5f1c93161f3582ae.md Outdated Show resolved Hide resolved
...-22/learn-basic-dom-manipulation-by-building-a-role-playing-game/62a3b49686792938718b90d3.md Outdated Show resolved Hide resolved
...-22/learn-basic-dom-manipulation-by-building-a-role-playing-game/62a3c0ab883fd9435cd5c518.md Outdated Show resolved Hide resolved
...-22/learn-basic-dom-manipulation-by-building-a-role-playing-game/62a8cce1b0c32c33017cf2e9.md Outdated Show resolved Hide resolved
jdwilkin4 and others added 7 commits April 17, 2024 19:02
@jdwilkin4 @Ksound22
Apply suggestions from code review
076b95e 
Co-authored-by: Kolade Chris <65571316+Ksound22@users.noreply.github.com>
@jdwilkin4 @Ksound22
Update curriculum/challenges/english/15-javascript-algorithms-and-dat…
6cb7c53 
…a-structures-22/learn-basic-dom-manipulation-by-building-a-role-playing-game/62a23cb9bc467a147516b500.md

Co-authored-by: Kolade Chris <65571316+Ksound22@users.noreply.github.com>
@Re1nGer @jdwilkin4
fix(curriculum): merge sort algorithm tests steps - 12,13,29 (freeCod…
01f5131 
…eCamp#54196)
@jdwilkin4
refactor(curriculum): update calorie counter project steps 1 - 37 (fr…
9e340fa 
…eeCodeCamp#54231)
@camperbot @jdwilkin4
chore(i18n,client): processed translations (freeCodeCamp#54323)
eb4e410
@weilirs @jdwilkin4 @Ksound22
fix(curriculum): update statistics calculator: step 27 (freeCodeCamp#…
57d8e07 
…53196)

Co-authored-by: jdwilkin4 <jwilkin4@hotmail.com>
Co-authored-by: Jessica Wilkins <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Kolade Chris <65571316+Ksound22@users.noreply.github.com>
Co-authored-by: Naomi <nhcarrigan@gmail.com>
@Sembauke @jdwilkin4
refactor: remove component library as internal dependency (freeCodeCa…
5253297 
…mp#54322)
ojeytonwilliams and others added 27 commits April 17, 2024 19:07
@ojeytonwilliams @jdwilkin4
refactor: simplify get challenges (freeCodeCamp#54335)
cd751c8
@Rabberpoli @huyenltnguyen @jdwilkin4
fix(curriculum): removed hyphens searching for topic from coding pages (
79ce0d3 
freeCodeCamp#54294)

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
@Ronilpatil22 @jdwilkin4
fix(curriculum): typo in step 47 binary project (freeCodeCamp#54390)
b9c8179
@jenna5376 @huyenltnguyen @jdwilkin4
fix(curriculum): spacing issue for step 17 of rpg project (freeCodeCa…
7c5f1bb 
…mp#54362)

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
@benzoms @jdwilkin4
fix(tools): better alert messaging (freeCodeCamp#54383)
b6154e9 
Co-authored-by: Ben Zhang <bz2065@nyu.edu>
@samimwebdev @jdwilkin4
fix(curriculum): update steps 18 and 19 for date formatter project (f…
81988ff 
…reeCodeCamp#54385)
@ojeytonwilliams @jdwilkin4
refactor(api): clean up route code (freeCodeCamp#54351)
adf2a6b
@Sembauke @moT01 @jdwilkin4
feat: The Odin Project function basics (freeCodeCamp#54349)
c3441e1 
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
@Supravisor @jdwilkin4
fix(curriculum): update tests for Football Teams step 25 to accept bo…
9cedfee 
…th types of functions (freeCodeCamp#54381)
@camperbot @jdwilkin4
chore(i18n,client): processed translations (freeCodeCamp#54396)
3bd15a5
@huyenltnguyen @jdwilkin4
fix(client): forum search link for English challenges missing block n…
e018bdd 
…ame (freeCodeCamp#54393)
@jenna5376 @jdwilkin4
fix: modified tests for step 10 of building a spam filter (freeCodeCa…
31b10b6 
…mp#54364)

Co-authored-by: Naomi <nhcarrigan@gmail.com>
@camperbot @jdwilkin4
chore(i18n,learn): processed translations (freeCodeCamp#54399)
1ce5713
@lasjorg @jdwilkin4
fix(curriculum): clarify instructions (freeCodeCamp#54404)
a235ba3
@lasjorg @jdwilkin4
fix(curriculum): correct instructions, add quotes around value (freeC…
c1275b9 
…odeCamp#54406)
@jenna5376 @jdwilkin4
fix(curriculum): updated step 27 of music player to accept let declar…
d600bdf 
…ation (freeCodeCamp#54407)
@ShaunSHamilton @jdwilkin4
chore(client): remove execute-challenge-saga log (freeCodeCamp#54412)
022d347
@ojeytonwilliams @jdwilkin4
chore(deps): update playwright (freeCodeCamp#54410)
1f27db4
@Supravisor @Sembauke @jdwilkin4
fix(curriculum): update example description in accessibility quiz ste…
9358067 
…p 8 (freeCodeCamp#54374)

Co-authored-by: Sem Bauke <semboot699@gmail.com>
@a2937 @jdwilkin4
fix(i18n): use translated text for play button (freeCodeCamp#54401)
305c5a9
@Sembauke @jdwilkin4
test(e2e): migrate image picture check tests to playwright (freeCodeC…
54261db 
…amp#54273)
@a2937 @jdwilkin4
fix(curriculum): use security as said in the clip (freeCodeCamp#54414)
e0b8f60
@camperbot @jdwilkin4
chore(i18n,client): processed translations (freeCodeCamp#54421)
38b544c
@Auxdible @jdwilkin4
fix(curriculum): update editable regions for step 47 of calorie count…
5d4becd 
…er (freeCodeCamp#54424)
@camperbot @jdwilkin4
chore(i18n,learn): processed translations (freeCodeCamp#54425)
44c67e0
@Sembauke @jdwilkin4 @Ksound22
feat: new introductory javascript project (freeCodeCamp#54305)
8e42130 
Co-authored-by: Sem Bauke <semboot699@gmail.com>
Co-authored-by: Jessica Wilkins <67210629+jdwilkin4@users.noreply.github.com>
Co-authored-by: Kolade Chris <65571316+Ksound22@users.noreply.github.com>
@Aryakoste @jdwilkin4
fix(curriculum): update description and hint text of Date Formatter -…
a774fa0 
… Step 28 (freeCodeCamp#54419)
@github-actions github-actions bot added the platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. label Apr 18, 2024
@jdwilkin4
Copy link
Contributor Author

ahhh... crap.

I am just going to create a clean PR

@jdwilkin4 jdwilkin4 closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ksound22 Ksound22 Ksound22 left review comments

@naomi-lgbt naomi-lgbt Awaiting requested review from naomi-lgbt

@JoyShaheb JoyShaheb Awaiting requested review from JoyShaheb

Assignees

@jdwilkin4 jdwilkin4

Labels
DO NOT MERGE new javascript course These are for issues dealing with the new JS curriculum platform: api Server application that needs familiarity with Express, Loopback, MongoDB etc. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet