Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bio component to profile page #54285

Merged

Conversation

shootermv
Copy link
Contributor

@shootermv shootermv commented Apr 3, 2024

bio section of the profile page
desktop:
image
mobile:
image

related to #48234

@shootermv shootermv requested a review from a team as a code owner April 3, 2024 08:36
@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Apr 3, 2024
@ahmaxed
Copy link
Member

ahmaxed commented Apr 3, 2024

Thanks for the pr and sorry for the confusion. those three dots (

) are the current socials, and the image should be on the left. Also I would be great if you could look into the failing tests.

@shootermv
Copy link
Contributor Author

ahmaxed

here is some problem with those icons: they only shown when user has some data at those fields,
currently development user has no data - so the no icons will display...
does this means - i should create some PR with modified seed scripts in a way the development user will have for example -github account?

@Sembauke
Copy link
Member

Sembauke commented Apr 4, 2024

here is some problem with those icons: they only shown when user has some data at those fields, currently development user has no data - so the no icons will display... does this means - i should create some PR with modified seed scripts in a way the development user will have for example -github account?

Hey @shootermv,
It is possible to add your own info to the developer account by going to the settings. There you should see a couple of fields were you can put your GitHub link etc..

@shootermv shootermv force-pushed the add-bio-component-to-profile-page branch from e34f3a5 to c247ef6 Compare April 7, 2024 06:24
@huyenltnguyen huyenltnguyen added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 9, 2024
@shootermv shootermv force-pushed the add-bio-component-to-profile-page branch 6 times, most recently from ca5664d to 195416f Compare April 21, 2024 12:05
@naomi-lgbt naomi-lgbt added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Apr 25, 2024
@Sembauke
Copy link
Member

Sembauke commented Apr 29, 2024

Hey @shootermv,

A couple of things:

  1. We should only add new classes when absolutely necessary, meaning the colour classes are redundant as we use predefined colours. You can view these colours in the developer console:
image

or in the global.css file. We do this to prevent duplication and to make sure that colours are both fit for light and dark theme.
2. The new component should have a width that correlates to the others. Meaning the bio components seems to have a larger width than say, the points component.

Again, thank you for working on this. If you have any questions let me know here.

@Sembauke Sembauke removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 29, 2024
Copy link
Member

@Sembauke Sembauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view comment above.

@Sembauke Sembauke added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 29, 2024
@shootermv shootermv force-pushed the add-bio-component-to-profile-page branch from 195416f to 204b85c Compare April 29, 2024 19:33
@shootermv shootermv force-pushed the add-bio-component-to-profile-page branch from 9e45451 to 2a3824d Compare April 30, 2024 14:34
@Sembauke Sembauke added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 2, 2024
@github-actions github-actions bot added the scope: i18n language translation/internationalization. Often combined with language type label label May 2, 2024
@ahmaxed ahmaxed merged commit c17587f into freeCodeCamp:main May 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants